Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: openfast 4.0 update? #1432

Closed
marchdf opened this issue Jan 6, 2025 · 10 comments · Fixed by #1441
Closed

Discussion: openfast 4.0 update? #1432

marchdf opened this issue Jan 6, 2025 · 10 comments · Fixed by #1441
Labels
enhancement New feature or request

Comments

@marchdf
Copy link
Contributor

marchdf commented Jan 6, 2025

OpenFAST updated it's main branch to 4.0.

Two things to consider, one easy, one not:

The holy grail would be to support both 3.x and 4.x. But... we've had this discussion before and it is not easy.

Users: thoughts?

@marchdf marchdf added the enhancement New feature or request label Jan 6, 2025
@rybchuk
Copy link
Contributor

rybchuk commented Jan 6, 2025

Talking to some of the devs, it seems like 4.0 will be a short term release, and 5.0 is right around the corner and that will be a long-term version. I can't pin a specific timeline to that, but it might be worthwhile saving the coding effort for 5.0

@lawrenceccheung
Copy link
Contributor

I think we might need to be supporting OpenFAST v3.5 turbine models for a while too. Not all turbines have been upgraded to 4.0, and there isn't an automatic upgrade utility/path for turbine models. Which means updating models by hand could be an error-prone, frustrating process.

However, I also see that we might need OpenFAST 4.0 and AMR-Wind for some of the benchmarking work, so maybe we need both? This holy grail could turn into a necessary, everyday grail soon.

Lawrence

@marchdf
Copy link
Contributor Author

marchdf commented Jan 6, 2025

Just for my education. What are the features in 4.0 that we "need" (in the vaguest sense) ?

@lawrenceccheung
Copy link
Contributor

My understanding was that we needed the latest beamdyn in OF 4.0, and also to get a consistent, stable build for the blade resolved cases. @ndevelder, do I have that right?

@marchdf
Copy link
Contributor Author

marchdf commented Jan 6, 2025

In the dev meeting, we talked of having a compile definition for the openfast version. The user would compile amr-wind against the openfast version they wanted and would need to specify that version as a cmake option. Would users be ok with this option?

@lawrenceccheung
Copy link
Contributor

yes, that would work. In spack-manager we also might need to put in safeguards so that nobody tries to build exawind-manager with OF 3.5 or below.

@andrew-platt
Copy link

For clarification from the OpenFAST side:

  • we intend to support 3.5.x for another year or two with bug fixes (no new features)
  • there were some BeamDyn improvements made in 3.5.5, but not in 4.0.0 (BD is identical between these versions). There were some slight performance improvements with 3.5.5 (up to 30% speed increase), and a little improvement in stability (marginal compared to what is coming with 5.0)
  • Version 5.0.0 will include tight coupling which will improve stability and speed with BeamDyn
  • Once 5.0.0 is released, we will likely reduce support of 4.0.0
    • Module input files will not change much from 4.0 to 5.0, but the main input file will change significantly.

@marchdf
Copy link
Contributor Author

marchdf commented Jan 7, 2025

Thanks for that @andrew-platt! Do you anticipate any changes to the fast library API between 4.0 and 5.0?

@andrew-platt
Copy link

andrew-platt commented Jan 7, 2025

I don't currently expect there will be any changes in that API from 4.0 to 5.0 -- most of the changes will be internal in the solver. If there are any changes, they would be relatively minor compared to what happened between 3.5.x and 4.0

@hgopalan
Copy link
Contributor

hgopalan commented Jan 9, 2025

For our project, we would prefer that we have an option to use OpenFAST 4.0 with AMR-Wind. We had deployed the version 3.5 in our December deployment and would like to use the newer version since OpenFAST 4.0 is also used with the other NREL tools used in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants