Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialization of rng #245

Closed
bkamins opened this issue Aug 11, 2023 · 2 comments
Closed

Initialization of rng #245

bkamins opened this issue Aug 11, 2023 · 2 comments

Comments

@bkamins
Copy link

bkamins commented Aug 11, 2023

Following my post https://bkamins.github.io/julialang/2023/08/11/evotrees.html

maybe you could consider changing (and related lines)

https://github.com/Evovest/EvoTrees.jl/blob/main/src/models.jl#L37

to something that does not affect task local RNG state?

(this is what https://github.com/Evovest/EvoTrees.jl/blob/main/src/models.jl#L35 for older versions of Julia)

Also - maybe it would be worth to add a comment (as probably many users will not be aware of it) that to get full reproducibility of a model one should pass RNG (and not just a seed). As currently the results of building of a model would depend on Julia version used.

Thank you for developing such a fantastic package.

@jeremiedb
Copy link
Member

Should be resolved with following section in docs: https://evovest.github.io/EvoTrees.jl/dev/#Reproducibility
As well as the rng now always being MersenneTwister.

@bkamins
Copy link
Author

bkamins commented Aug 19, 2023

Bravo! Top quality. Thank you!

@bkamins bkamins closed this as completed Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants