Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underlined space when using -Collapsable #51

Closed
whoot opened this issue Oct 1, 2019 · 5 comments
Closed

Underlined space when using -Collapsable #51

whoot opened this issue Oct 1, 2019 · 5 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@whoot
Copy link

whoot commented Oct 1, 2019

Hey, thanks for the fix of the "Missing space character when using '-Collapsable'" issue.
However, the space gets unerlined now:

grafik

@PrzemyslawKlys PrzemyslawKlys added bug Something isn't working enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 1, 2019
@Tuxhedoh
Copy link
Contributor

Tuxhedoh commented Oct 1, 2019

I'd be happy to attempt this if you can point me to the file that has this. I attempted to find the fix that was mentioned in the issue, but couldn't find where it was addressed.

@PrzemyslawKlys
Copy link
Member

It's in the last else:

New-HTMLAnchor -Id "show_$RandomNumber" -Href 'javascript:void(0)' -OnClick "show('$RandomNumber');" -Style $ShowStyle -Text ' (Show)'
New-HTMLAnchor -Id "hide_$RandomNumber" -Href 'javascript:void(0)' -OnClick "hide('$RandomNumber');" -Style $HideStyle -Text ' (Hide)'

Basically what needs to be done is one needs to remove space from -Text field on lines 121 and 122 and move that into line 120 (basically add space to $HeaderText instead.

New-HTMLAnchor -Name $HeaderText -Text $HeaderText -Style $HeaderStyle

@PrzemyslawKlys
Copy link
Member

I guess better looking would be only link to Hide/Show word without () but that's a bit harder. You would probably need to write New-HTMLTag -Tag a and all that stuff to build a better version of it.

@PrzemyslawKlys
Copy link
Member

Closing. Will release fix this weekend with some other stuff probably.

@PrzemyslawKlys
Copy link
Member

Thanks, Tuxhedoh for help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants