Replace etc/no-deprecated with eslint-plugin-deprecation

[EvgenyOrekhov]

https://github.com/gund/eslint-plugin-deprecation

Unless cartant/eslint-plugin-etc#53 gets fixed.

[EvgenyOrekhov]

Or with sonar/deprecation from https://github.com/un-ts/eslint-plugin-sonar

[voxpelli]

What's the benefits over https://github.com/import-js/eslint-plugin-import/blob/HEAD/docs/rules/no-deprecated.md ?

(Reference voxpelli/eslint-config#160)

[EvgenyOrekhov]

@voxpelli

Just tested the rules on a real-world codebase:

• etc/no-deprecated - 78 warnings
• deprecation/deprecation - 76 warnings
• sonar/deprecation - 76 warnings
• import/no-deprecated - 54 warnings

So import/no-deprecated catches less cases.

Created #739 to disable import/no-deprecated for TS, since it's superseded by etc/no-deprecated.

[voxpelli]

Right, makes sense, type resolutions can be more complex

What are the two warnings that differ between the 78 and 76 ones?

[EvgenyOrekhov]

@voxpelli Seems like etc/no-deprecated just sometimes gives duplicated warnings, like

140:45  error  "pageYOffset" is deprecated: This is a legacy alias of `scrollY`  etc/no-deprecated	
140:45  error  "pageYOffset" is deprecated: This is a legacy alias of `scrollY`  etc/no-deprecated

Also tested time difference:

• etc/no-deprecated - 47 seconds
• deprecation/deprecation - 57 seconds
• sonar/deprecation - 52 seconds

[voxpelli]

Yikes, yeah, these rules can be really slow, I tried adding deprecation checks to a large monorepo at a recent job and it increased the execution time of the linting so much that I reverted on it before ever suggesting the change 😕

[DeadlyMissile]

So which one of these is recommended to use lol?

[EvgenyOrekhov]

@DeadlyMissile I considered migrating away from etc/no-deprecated because it wasn't compatible with TypeScript v5, but now it is, so I'll stick to it for now, especially since it's a bit faster than the others.

But functionality-wise, all three are the same.

[CHE1RON]

Sorry to add to an old issue @EvgenyOrekhov, but it seems to break with Typescript 5.2, see cartant/eslint-plugin-etc#64