Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing filter after selecting a row #170

Closed
TuanSSM opened this issue May 2, 2024 · 3 comments
Closed

Clearing filter after selecting a row #170

TuanSSM opened this issue May 2, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@TuanSSM
Copy link

TuanSSM commented May 2, 2024

Hello, first of all thanks for your efforts on this project.

After applying a filter to the table and selecting a row, if I clear the filter, the table does not revert to its initial state with selections.

Before filtering

Selection with filter

Filter cleared

@Evertras Evertras added the bug Something isn't working label May 3, 2024
@Evertras
Copy link
Owner

Evertras commented May 3, 2024

Just reproduced, definitely an interesting bug. I think it's because of how the rows are replaced internally during some operations... I'll take a look into this, this needs to be fixed.

@Evertras
Copy link
Owner

Evertras commented May 3, 2024

This should be fixed now. I redid how we update the selection toggle, which has the added benefit of also being faster than the old way, so hopefully this is a win/win for everyone. Thanks for the report!

Try v0.15.8 and feel free to close if that fixes it, or let me know if there's anything still broken.

@TuanSSM
Copy link
Author

TuanSSM commented May 6, 2024

Works flawless, thank you for quick fix 👑

@TuanSSM TuanSSM closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants