Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connect .count() broken #3347

Open
andrewgazelka opened this issue Nov 20, 2024 · 0 comments
Open

fix: connect .count() broken #3347

andrewgazelka opened this issue Nov 20, 2024 · 0 comments

Comments

@andrewgazelka
Copy link
Member

pub fn handle_count(_arguments: Vec<daft_dsl::ExprRef>) -> eyre::Result<daft_dsl::ExprRef> {
error!("Warning: count function not yet supported; using placeholder 1 instead; see https://github.com/Eventual-Inc/Daft/issues/1979");
Ok(daft_dsl::lit(1))
// let arguments: [daft_dsl::ExprRef; 1] = match arguments.try_into() {
// Ok(arguments) => arguments,
// Err(arguments) => {
// bail!("requires exactly one argument; got {arguments:?}");
// }
// };
//
// let [arg] = arguments;
//
// Ok(arg.count(CountMode::All)) // todo(correctness): is this correct? The CountMode and all?
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant