Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: allow table select in join #3070

Closed
ukclivecox opened this issue Oct 18, 2024 · 0 comments · Fixed by #3074
Closed

SQL: allow table select in join #3070

ukclivecox opened this issue Oct 18, 2024 · 0 comments · Fixed by #3074
Labels
enhancement New feature or request sql

Comments

@ukclivecox
Copy link

Is your feature request related to a problem?

If you try to select all columns in a table after a join you get a not yet implemented error.

import daft

df1 = daft.from_pydict({"idx":[1,2],"val":[10,20]})

df2 = daft.from_pydict({"idx":[1,2],"score":[0.1,0.2]})

df_sql = daft.sql("select df2.* from df1 left join df2 on (df1.idx=df2.idx)").show()

Screenshot_2024-10-18_10-11-48

Describe the solution you'd like

Ability to select all columns in a joined table.

Describe alternatives you've considered

No easy solution - you could if you knew the columns select then 1 by 1 and join into 1 table...

Additional Context

Testing with nightly build 0.3.8+dev0019.e4c6f3fa that has additions for joins from #3066

Would you like to implement a fix?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sql
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants