Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing on angular > 1.2.25 #28

Open
w33ble opened this issue Dec 19, 2014 · 1 comment
Open

Tests failing on angular > 1.2.25 #28

w33ble opened this issue Dec 19, 2014 · 1 comment

Comments

@w33ble
Copy link

w33ble commented Dec 19, 2014

The travis build on v1.4.3 passed with angular and angular-mocks v1.2.25

Running them again with a newer 1.2 version results in a failing test.

AssertionError: expected 2 to equal 1
        at /Users/d33t/repos/angular-selectize.js/node_modules/chai/chai.js:873
        at assertEqual (/Users/d33t/repos/angular-selectize.js/node_modules/chai/chai.js:1386)
        at /Users/d33t/repos/angular-selectize.js/node_modules/chai/chai.js:3627
        at /Users/d33t/repos/angular-selectize.js/node_modules/chai/chai.js:2483
        at testSelectedOption (/Users/d33t/repos/angular-selectize.js/test/selectNgOptions.spec.js:45)
        at /Users/d33t/repos/angular-selectize.js/test/selectNgOptions.spec.js:188

The current bower pattern of ^1.2.5 actually matches the 1.3 branch, which results in 16 failed tests.

PhantomJS 1.9.8 (Mac OS X): Executed 106 of 109 (16 FAILED) (1.102 secs / 0.136 secs)

Based on the tests failing, and the fact that angular doesn't follow semver, the bower pattern should definitely be "~1.2.5". Even with that change though, there's a test that needs to be fixed here.

This was referenced Dec 19, 2014
@w33ble
Copy link
Author

w33ble commented Dec 19, 2014

Starting in angular 1.2.26, this is what the domOptions looks like for the one failing test:

[<option value=​"? string:​foo ?">​</option>​, <option value=​"0" selected=​"selected">​</option>​]

the extra <option value=​"? string:​foo ?">​</option>​ in there is what causes the test to fail.

Looks like selectize.removeOption('?'); here fails - something about newer versions of angular are causing the option's value to be different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant