Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multisig.sol interface function definitions caused Remix compiler error when inherited. (medium severity) #6

Open
Dexaran opened this issue Feb 10, 2018 · 0 comments
Labels

Comments

@Dexaran
Copy link
Member

Dexaran commented Feb 10, 2018

Severity: medium

Code snippet

https://github.com/EthereumCommonwealth/ethereum-classic-multisig/blob/master/contracts/ownership/Multisig.sol#L25-L27

Description

It does not matter whether an empty function is defined as function func() external; or function func() external { }. In case of function func() external; definition Remix is unable to return the contract's bytecode.

It is highly advised to use function func() { } for empty function definitions.

Recommendation

contract Multisig {
  function changeOwner(address _from, address _to) external { }
  function execute(address _to, uint256 _value, bytes _data) external returns (bytes32) { }
  function confirm(bytes32 _h) public returns (bool) { }
}
@Dexaran Dexaran added the audit label Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant