Missing function visibility specifier (low severity, code readability)

[Dexaran]

Severity: low

Code snippet

https://github.com/EthereumCommonwealth/ethereum-classic-multisig/blob/master/contracts/ownership/Multisig.sol#L27

Description

It is strongly recommended to adhere to the same coding standard when developing important components of blockchain systems such as multisig wallet.

Unlike the other functions, confirm(bytes32 _h) does not have a visibility specifier.

Recommendation

Implement a public visibility specifier for confirm function of the Multisig.sol and MultisigWallet.sol contracts as follows:

contract Multisig {
  function confirm(bytes32 _h) public returns (bool) { }
}

contract MultisigWallet is Multisig, Shareable, DayLimit {

  /**
   * @dev Confirm a transaction by providing just the hash. We use the previous transactions map,
   * txs, in order to determine the body of the transaction from the hash provided.
   * @param _h The transaction hash to approve.
   */
  function confirm(bytes32 _h) public onlymanyowners(_h) returns (bool) {
    if (txs[_h].to != 0) {
      assert(txs[_h].to.call.value(txs[_h].value)(txs[_h].data));
      MultiTransact(msg.sender, _h, txs[_h].value, txs[_h].to, txs[_h].data);
      delete txs[_h];
      return true;
    }
  }
}