Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract inner variables visibility (low severity) #3

Open
Dexaran opened this issue Feb 5, 2018 · 0 comments
Open

Contract inner variables visibility (low severity) #3

Dexaran opened this issue Feb 5, 2018 · 0 comments
Labels

Comments

@Dexaran
Copy link
Member

Dexaran commented Feb 5, 2018

Severity: low

Code snippet

txs mapping at MultisigWallet.sol

owners array at Shareable.sol

owner index mapping at Shareable.sol

pendings mapping at Shareable.sol

pendingsIndex at Shareable.sol

Description

It is always possible to restore the history of contract calls. As a result, anyone can always find out the state of the internal contract variables. It may be useful to know the contract inner variables in some cases or access it artificially while hiding them has no benefits or reasons.

Recommendation

Specify public visibility for the named variables list.

@Dexaran Dexaran added the audit label Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant