-
Notifications
You must be signed in to change notification settings - Fork 155
is @types/geojson better off as a devDependency? #305
Comments
@jgravois - Personally I am okay with adding I suppose its a trade off/compromise for someone. People using an internal npm registry could host the new required dependency or people using the typescript definition could work around issue by knowing to add the |
Just wanted to highlight this comment from related discussion. microsoft/types-publisher#81 (comment) I think it summarizes things well. The best choice for a lib is |
isn't everything. 😄 my guess is that the number of TypeScript Terraformer developers outnumber the vanilla JS developers using private npm registries. for now i'll just leave this issue open to collect 👍 and 👎 s. |
👍 === For leaving things as is. My vote is 👍 . But I can live with the alternative. |
Thanks for considering this issue! This broke our installation of Sequelize. We are using a private server, and the error is SUPER not helpful. Please err on the side of VanillaJS, as a few big projects seem to be using this library as a dependency, and most devs aren't using Typescript (although it would be nice!) I installed Sequelize in a new project using our private server just 3 weeks ago, and it worked just fine. But today, not so much:
Regards, |
a few users reported errors when attempting to install
v1.0.8
(see #304) because they are using an internal npm registry.this got me thinking that @types/geojson should really only be a
devDependency
because Terraformer doesn't actually require that it be present to function.related discussion: microsoft/types-publisher#81 (comment)
@darcyparker is there a way that TypeScript developers can get what they need for Terraformer automatically without those additional libraries being downloaded by everyone?
The text was updated successfully, but these errors were encountered: