-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Geometry::estimateMemorySize() API #156
Comments
If are working on this, would you be willing to add an abstract method to the Geometry class and other classes as needed called estimateMemorySize() that returns the size of the geometry instance in memory? |
|
@stolstov Sergey, thanks for a quick response. Absolutely, I'd be happy to work on a PR to add estimateMemorySize() to the Geometry objects. Is there anything I should be aware of/read about before starting? |
@mbasmanova That would be great if you could add those methods. Please, use same formatting as we do, and read CONTRIBUTING.md (which is basically a link to this https://github.com/esri/contributing) for the legal info. |
@alocke Could you verify this? |
Yes, I will. |
@alocke Annette, I'd like to use the new API in Presto https://prestodb.io/ . Do you have an idea of when a new release might be available? |
@mbasmanova Thank you. Verified. |
@alocke Thank you, Annette! What are the next steps? |
@mbasmanova Thank you! |
@randallwhitman Randall, thanks for releasing the new version. Will it appear on Maven Central automatically within a short period of time or is something else necessary to make this happen? https://mvnrepository.com/artifact/com.esri.geometry/esri-geometry-api |
I ran |
@randallwhitman Randall, I see 2.1.0 release in Maven central: https://mvnrepository.com/artifact/com.esri.geometry/esri-geometry-api/2.1.0 Thank you so much! |
I'm using ESRI Geometry API to provide geospatial query support in Presto ( https://prestodb.io/ ) and I need to calculate how much memory individual Geometry objects occupy. I'm using ClassLayout.parseClass to compute the base size of an object and then add on sizes of arrays, lists, etc. I need to be able to write this code:
(see https://github.com/prestodb/presto/pull/9474/files#diff-ac9e6026ae8bd12a435b09b61a5cc0fa)
But I can't because MultiPointImpl and MultiPathImpl classes are package private.
Would it be possible to make them public?
The text was updated successfully, but these errors were encountered: