Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(text-area): add component token E2E tests #9729

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jul 3, 2024

✨🧪✨

@jcfranco jcfranco requested a review from a team as a code owner July 3, 2024 17:04
}
textarea:focus {
--calcite-internal-text-area-border-color: var(--calcite-text-area-border-color, var(--calcite-color-status-danger));
//--calcite-internal-text-area-border-block-end-color: var(--calcite-internal-text-area-border-color);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick : can we remove this.

Copy link
Contributor

@anveshmekala anveshmekala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jcfranco jcfranco merged commit 94fb823 into epic/7180-component-tokens Jul 5, 2024
4 checks passed
@jcfranco jcfranco deleted the jcfranco/7180-add-text-area-component-token-e2e-tests branch July 5, 2024 21:49
benelan added a commit that referenced this pull request Jul 9, 2024
… benelan/reset-chromatic-tokens-epic

* origin/epic/7180-component-tokens: (222 commits)
  test(text-area): add component token E2E tests (#9729)
  test(themed): improve pseudoElement pattern
  test(rating): add theme token tests (#9700)
  test(block, block-section): add component token E2E tests (#9685)
  test(button, fab): add component token E2E tests (#9602)
  test(inline-editable): add token theme tests (#9648)
  fix(list, list-item, list-item-group): add e2e themed tests (#9616)
  test(shell-center-row): add token theming tests (#9462)
  test(shell): add token theming tests (#9458)
  fix build issues
  test(combobox, combobox-item-group, combobox-item): add component token E2E tests (#9599)
  test(radio-button): add component token E2E tests (#9591)
  test(card, card-group): add component token E2E tests (#9600)
  test(select): add component token E2E tests (#9593)
  test(icon): add component token E2E tests (#9595)
  test(label): add component token E2E tests (#9594)
  test(switch): add component token E2E tests (#9596)
  test(graph): add component token E2E tests (#9597)
  test(dropdown, dropdown-group): add component token E2E tests (#9598)
  test(tip, tip-group, tip-manager): add component token E2E tests (#9589)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants