Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dropdown): fix dropdown E2E suite grouping #8319

Merged
merged 2 commits into from
Dec 6, 2023
Merged

test(dropdown): fix dropdown E2E suite grouping #8319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf40a05
test(dropdown): fix dropdown E2E suite grouping
jcfranco Dec 1, 2023
e72a650
merge main
jcfranco Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/calcite-components/conventions/Styling.md
View file
Open in desktop
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -101,6 +101,6 @@ All components have been constructed to inherit their `font-family`. This enable


The Esri color palette can be found [here](https://esri.github.io/calcite-colors/). The Esri color palette can be found [here](https://esri.github.io/calcite-colors/).


**Discussed In**: __Discussed In__:
Copy link
Member Author

@jcfranco jcfranco Dec 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was autofixed after merging main.



- <https://github.com/Esri/calcite-design-system/issues/507> - <https://github.com/Esri/calcite-design-system/issues/507>
7 changes: 2 additions & 5 deletions packages/calcite-components/src/components/dropdown/dropdown.e2e.ts
View file
Open in desktop
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ describe("calcite-dropdown", () => {
defaultValue: "bottom-start", defaultValue: "bottom-start",
}, },
]); ]);
});


describe("reflects", () => { describe("reflects", () => {
reflects("calcite-dropdown", [ reflects("calcite-dropdown", [
Expand Down Expand Up @@ -94,10 +95,7 @@ describe("calcite-dropdown", () => {
* @param root0 * @param root0
* @param root0.expectedItemIds * @param root0.expectedItemIds
*/ */
async function assertSelectedItems( async function assertSelectedItems(page: E2EPage, { expectedItemIds }: SelectedItemsAssertionOptions): Promise<void> {
page: E2EPage,
{ expectedItemIds }: SelectedItemsAssertionOptions
): Promise<void> {
await page.waitForTimeout(100); await page.waitForTimeout(100);
const selectedItemIds = await page.evaluate(() => { const selectedItemIds = await page.evaluate(() => {
const dropdown = document.querySelector<HTMLCalciteDropdownElement>("calcite-dropdown"); const dropdown = document.querySelector<HTMLCalciteDropdownElement>("calcite-dropdown");
Expand Down Expand Up @@ -1346,4 +1344,3 @@ describe("calcite-dropdown", () => {
}); });
}); });
}); });
});
Loading