feat: support setting form ID on form components #6682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
benelan
approved these changes
Mar 28, 2023
src/components/button/button.tsx
Outdated
| @@ -75,6 +74,14 @@ export class Button | |||
| /** When `true`, interaction is prevented and the component is displayed with lower opacity. */ | |||
| @Prop({ reflect: true }) disabled = false; | |||
|
|
|||
| /** | |||
| * The ID of the form owner to associate this component with. | |||
There was a problem hiding this comment.
Maybe "The ID of the form owner to associate with the component"? IIRC ending a sentence with "with" is frowned upon by the dictionary dwellers. Applies to the other components as well.
jcfranco
deleted the
jcfranco/5164-support-setting-form-ID-for-form-components
branch
github-actions
bot
added this to the 2023 April Priorities - No breaking changes milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5164
Summary
This allows developers to associate form components by providing the form ID.
Notes
Follow-up
I'll DRY up some duplication in the
commonTests#formAssociatedtest helper in a separate PR. I went this route to expedite testing.