From 1039e52049be86052cfca843d7c6c6e9595d5ddf Mon Sep 17 00:00:00 2001 From: Eliza Khachatryan Date: Wed, 1 Mar 2023 20:21:57 -0800 Subject: [PATCH 1/2] fix(slider): range slider thumb on PC tablet now follows touch gesture --- src/components/slider/slider.scss | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/components/slider/slider.scss b/src/components/slider/slider.scss index ad13bab1aef..fa9357be474 100644 --- a/src/components/slider/slider.scss +++ b/src/components/slider/slider.scss @@ -34,8 +34,11 @@ font-size: var(--calcite-slider-container-font-size); } +// disable browser swipe navigation to next/previous page to prevent +// interference with the slide thumb intended functionality to follow touch gesture :host { @apply block; + touch-action: none; } .container { From f40ab32dd8435549bb3d20cefcd338b0507a2586 Mon Sep 17 00:00:00 2001 From: Eliza Khachatryan Date: Thu, 2 Mar 2023 14:31:00 -0800 Subject: [PATCH 2/2] WIP: cleanup --- src/components/slider/slider.scss | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/components/slider/slider.scss b/src/components/slider/slider.scss index fa9357be474..2c9dcc88242 100644 --- a/src/components/slider/slider.scss +++ b/src/components/slider/slider.scss @@ -34,11 +34,8 @@ font-size: var(--calcite-slider-container-font-size); } -// disable browser swipe navigation to next/previous page to prevent -// interference with the slide thumb intended functionality to follow touch gesture :host { @apply block; - touch-action: none; } .container { @@ -50,6 +47,8 @@ --calcite-slider-full-handle-height: calc( var(--calcite-slider-handle-size) + var(--calcite-slider-handle-extension-height) ); + touch-action: none; + // disable browser swipe navigation to prevent interference with the slide thumb following a touch gesture } @include disabled() {