fix(tree): ensure lines length is accurate
#11036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anveshmekala
added
the
pr ready for visual snapshots
github-actions
bot
added
the
bug
anveshmekala
added
pr ready for visual snapshots
anveshmekala
changed the title
lines length is accurate.
anveshmekala
requested review from
ashetland
and removed request for
ashetland
|
🚀 |
jcfranco
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Nice!
Could you add a story or update the line-related story to help cover this?
Also, before merging, can you make sure the PR title subject follows our conventions and uses the imperative, present tense (e.g., ensure lines length is accurate or similar)?
Dont think we need a new story since it already covers the regression case in the new build here. |
anveshmekala
changed the title
lines length is accurate.lines length is accurate
jcfranco
changed the title
lines length is accuratelines length is accurate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #11035
Summary
Fixed
lineslength of parenttree-itemwith slotted children.BEGIN_COMMIT_OVERRIDE
fix(tree): ensure
lineslength is accurateEND_COMMIT_OVERRIDE