deprecate: deprecate web-adaptor in favor of web-adapter #10598
Conversation
github-actions
bot
added
the
enhancement
calcite-admin
added
the
skip visual snapshots
There was a problem hiding this comment.
Thanks for adding back the deprecated icons to prevent a breaking change. Can you please change the PR title to deprecate: deprecate web-adaptor in favor of web-adapter. That will make sure it ends up on the changelog so people know to migrate to the fixed icon names.
|
Does this also need an update to |
I think we want to remove deprecated icons from |
|
From a dev perspective, it’d be helpful to surface deprecation notices on the docs site. It could also help identify all icons slated for removal later. On that note, should we create an issue to track the removal of this icon for a future breaking change release? |
|
@arowles Thanks for restoring this so quickly, btw! 🎉 |
|
Yeah, maybe one issue for all of the future icon removals? We have some from #10309 too. @macandcheese can you add some logic to the icon finder for showing a deprecation chip/message? Should it just be a boolean I think we should wait until the doc site handles deprecations before adding them back to |
|
We could have a “deprecated in favor of” metadata field in addition to just deprecation as Boolean. We don’t need to show this to a user but we can use it to surface the new icon without showing the old name? I also think from a use case perspective this would solve the “why isn’t my icon working”, as I’d expect only searches for exact icon term to return the deprecated ones. We can work on the UI / UX of how we display this, I think the above metadata would be sufficient. |
arowles
changed the title
…orepo * origin/dev: build(deps): update typescript-eslint monorepo to v7.18.0 (#10593) feat(tile): add design tokens (#10476) deprecate: deprecate web-adaptor in favor of web-adapter (#10598) docs: update component READMEs (#10600) build(deps): update dependency @rollup/plugin-replace to v6 (#10604) chore: release main (#10597) ci(chromatic): build storybook even when skipping snapshots (#10589) build(deps): update dependency axe-core to v4.10.1 (#10566) ci: add calcite-ui-icons label to relevant package PRs (#10590) chore: release next feat: add buffer point, buffer polygon, buffer polyline, contour, offset (#10594) feat(input-date-picker, date-picker): improve date picking experience (#8402) chore: release next fix: updated web-adapter name (#10581) build(deps): update nrwl monorepo to v19.8.6 (#10575) build(deps): update dependency tsx to v4.19.1 (#10574) build(deps): update dependency @cspell/eslint-plugin to v8.15.4 (#10565)
Related Issue: #
Summary
added
web-adaptor