fix(tab-nav): fix custom element creation error in components build output
#9021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
changed the title
components build output
|
Sidebar: we could look into improving |
Yeah thats a good call 👍 |
jcfranco
added
the
skip visual snapshots
jcfranco
deleted the
jcfranco/9010-fix-tabs-setting-native-dir-attribute
branch
Merged
jcfranco
pushed a commit
that referenced
this pull request
Mar 30, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.7.1</summary> ## [2.7.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-03-29) ### Bug Fixes * **tab-nav:** Fix custom element creation error in `components` build output ([#9021](#9021)) ([cc8eb99](cc8eb99)) </details> <details><summary>@esri/calcite-components-angular: 2.7.1</summary> ## [2.7.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-03-29) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.7.1-next.0 to ^2.7.1 </details> <details><summary>@esri/calcite-components-react: 2.7.1</summary> ## [2.7.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-03-29) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.7.1-next.0 to ^2.7.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
geospatialem
modified the milestones:
2024-04-30 - Apr Release,
2.7.1 patch (March 2024) - Bugs only
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9010
Summary
Class members are defined on the component host in the
componentsoutput build, so we need to avoid using names ofHTMLElementmembers (dirin this case).Note: no additional tests were added since our testing setup uses the
distoutput target.