Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input message animates on DOM attachment #8677

Closed
2 of 6 tasks
nwhittaker opened this issue Jan 31, 2024 · 4 comments
Closed
2 of 6 tasks

Input message animates on DOM attachment #8677

nwhittaker opened this issue Jan 31, 2024 · 4 comments
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library

Comments

@nwhittaker
Copy link
Contributor

Check existing issues

Actual Behavior

When attaching a <calcite-input-message> element to the DOM, the size of the message fluctuates:

Screen.Recording.2024-01-31.at.9.43.20.AM.mov

Expected Behavior

The size of the message does not fluctuate:

Screen.Recording.2024-01-31.at.9.45.37.AM.mov

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/yLwvEMK

Reproduction Steps

  1. Visit the reproduction sample
  2. Click the Validate button to see the message (re)appear

Reproduction Version

2.3.0

Relevant Info

Similar to #4291.

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

Field Maps generates a form from user data. Each field in the form could show error or warning messages at various times in response to the user's interactions. Since the form could have any number of fields, we create input-message elements on-demand rather than all up-front (and initially hidden).

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Field Apps

@nwhittaker nwhittaker added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 31, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. p3 - want for upcoming milestone ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. labels Jan 31, 2024
@macandcheese
Copy link
Contributor

Agreed we probably don’t need to animate in at all, just show or hide this.

@jcfranco
Copy link
Member

This might be addressed by #8571.

@jcfranco jcfranco added estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Feb 29, 2024
@jcfranco
Copy link
Member

Confirmed! https://codepen.io/jcfranco/pen/bGJGjEJ

@jcfranco
Copy link
Member

Closing based on ☝️. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Development

No branches or pull requests

3 participants