Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary scroll bar in calcite-color-picker in Chrome & Edge #8379

Closed
2 of 6 tasks
tayMAPNeil opened this issue Dec 8, 2023 · 4 comments
Closed
2 of 6 tasks

Unnecessary scroll bar in calcite-color-picker in Chrome & Edge #8379

tayMAPNeil opened this issue Dec 8, 2023 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. regression Issues that are caused by changes in a release, but were working before that.
Milestone
2023 December Pri...

Comments

@tayMAPNeil
Copy link

tayMAPNeil commented Dec 8, 2023 •
edited
Loading

Check existing issues

Actual Behavior

A small, unnecessary scroll bar appears next to the RGB / HSV input section of the color-picker.

2023-12-08_11-33-11.mp4

Expected Behavior

No scrollbar should display.

Reproduction Sample

https://next.sites.afd.arcgis.com/calcite-design-system/components/color-picker/

Reproduction Steps

  1. Open the calcite-color-picker component sample on Chrome or Edge browser.
  2. See an unecessary scroll bar to the right of the HSV/RGB input.

Reproduction Version

1.10.0

Relevant Info

This is not an issue on the FF browser.

I was able to repro on a Windows PC using Edge or Chrome. My colleague on a Mac can also see the scrollbar on the sample page (image below).
image

Potentially related to #8139

Regression?

1.9.0

Priority impact

p3 - want for upcoming milestone

Impact

Relatively minor impact, but would be nice to fix. We leverage the color-picker in various areas of Map Viewer.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@tayMAPNeil tayMAPNeil added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Dec 8, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. labels Dec 8, 2023
@geospatialem
Copy link
Member

Thanks for filing, @tayMAPNeil!

Will work towards a solution in the linked issue mentioned above, #8139, and will verify if the fix mitigates the above color-picker issue once implemented (targeted for this month's release).

@geospatialem geospatialem mentioned this issue Dec 8, 2023
Closed
5 tasks
@geospatialem geospatialem added the regression Issues that are caused by changes in a release, but were working before that. label Dec 8, 2023
@geospatialem geospatialem self-assigned this Dec 11, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Dec 11, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Dec 11, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Dec 11, 2023
@eriklharper
Copy link
Contributor

Tested locally, and I'm no longer seeing the issue on latest. I think this fixed it: #8399.

@eriklharper eriklharper added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 13, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Dec 13, 2023 •
edited
Loading

Like @eriklharper mentioned, I think this was fixed with the issue he mentioned about. Closing this one.

@DitwanP DitwanP closed this as completed Dec 13, 2023
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
4 participants
@eriklharper @geospatialem @DitwanP @tayMAPNeil