-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Input Message to form components for form validation #8057
Comments
@ashetland, @SkyeSeitz - I updated the issue body, but TLDR; the following components needs designs for the
Not sure where the invalid coloring should be applied for slider. Just the handle? Or the whole slider? And then the other three all have child elements and I'm not sure how design wants the invalid styling, especially with focus.
And then |
Added the |
Segmented control follows the radio group pattern, which does allow for none of the items to be selected initially (we have a test for this use case as well), so I think |
…ted-control, select): add required property (#8517) **Related Issue:** #8057 ## Summary Remove the `@internal` tag from the `required` property on form components. --------- Co-authored-by: Kitty Hurley <[email protected]> Co-authored-by: Matt Driscoll <[email protected]>
**Related Issue:** #8057 ## Summary - Reflect the `validationIcon` - brought up in #8561 (comment) - Add `validationIcon`, `validationMessage`, and `status` properties to the reflects and defaults common tests - brought up in #8561 (comment)
Installed and assigned for verification. |
Verified in
|
The latest comment says that rating and slider should have a validationMessage property? is that still the case? should there be an issue? |
From my memory, they should have a validationMessage prop to go with its required prop. Since invalid styling is not really effective on these components, the validationMessage prop would serve as the only visual invalid affordance. |
Should we reopen this one or create a new one? @geospatialem @DitwanP |
Apologies this was missed when I was verifying - we had multiple issues that were related to form validation closing at once, and I didn't verify the effort for |
Check existing issues
Description
We are in the process of improving our form validation story. One of the items is to replace the native validation message UI with
calcite-input-message
(#8000). First wee need to add an Input Message to our form components.Acceptance Criteria
calcite-input-message
to our form components, which will display under the internal element.validation-message
andvalidation-icon
properties so users can change the message's values on their end.Relevant Info
No response
Which Component
The following input components need an internal input-message, and a
status
property if they don't have one.The following have the
required
property, which means they will need a validation message displayed via #8000.The following don't need an internal
input-message
for #8000 because they don't have any constraint validation properties. Should they receive an internalinput-message
anyway? If so, do they need astatus
property as well?Example Use Case
Form validation and other help messages.
Priority impact
p3 - want for upcoming milestone
Calcite package
Esri team
N/A
The text was updated successfully, but these errors were encountered: