Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit non-component event targets and update conventions #7468

Open
1 of 2 tasks
jcfranco opened this issue Aug 7, 2023 · 1 comment
Open
1 of 2 tasks

Audit non-component event targets and update conventions #7468

jcfranco opened this issue Aug 7, 2023 · 1 comment
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Milestone
2025-05-13 - 3.2....

Comments

@jcfranco
Copy link
Member

jcfranco commented Aug 7, 2023

Description

@Listen and custom events use document.body, document or window as targets/dispatchers. We should audit and update our conventions with information regarding the appropriate target to use per context.

Proposed Advantages

Consistent target/dispatching for non-component events.

Which Component

All components dispatching/listening events on document or document.body and possibly window.

Relevant Info

Stems from #7466 (comment)

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
@jcfranco jcfranco added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 7, 2023
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Aug 7, 2023
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels May 28, 2024
@geospatialem
Copy link
Member

Refer to Matt's PR with color-picker, popover, etc. to accommodate iframes: #8247

@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2025-05-13 - 3.2.0 May Main Release
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP