Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-button#form where form is not submitted/reset when the buttons are mounted before the form #6751

Open
brettephillips opened this issue Apr 7, 2023 · 4 comments
Open

calcite-button#form where form is not submitted/reset when the buttons are mounted before the form #6751

brettephillips opened this issue Apr 7, 2023 · 4 comments
Labels
0 - new New issues that need assignment. ArcGIS Velocity Issues logged by ArcGIS Velocity team members. blocked This issue is blocked by another issue. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-button Issues that pertain to the calcite-button component estimate - 8 Requires input from team, consider smaller steps. has workaround Issues have a workaround available in the meantime. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library p4 - not time sensitive User set priority status of p4 - not time sensitive
Milestone
Stalled

Comments

@brettephillips
Copy link

brettephillips commented Apr 7, 2023 •
edited by geospatialem
Loading

Actual Behavior

Give a submit or reset button associated with a non-ancestor form, clicking the button does not submit/reset the form. This scenario does not work when the buttons are mounted before the form.

Blocked issues: #8126

Expected Behavior

Give a submit or reset button associated with a non-ancestor form, clicking the button does submit/reset the form regardless of when the components have been mounted

Reproduction Sample

https://codesandbox.io/s/form-not-working-d5dc70?file=/src/App.js

Reproduction Steps

  1. Open the console and click the submit button and note "submitted" is not printed.

Reproduction Version

1.2.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Esri team

ArcGIS Velocity
@brettephillips brettephillips added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Apr 7, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive ArcGIS Velocity Issues logged by ArcGIS Velocity team members. labels Apr 7, 2023
@geospatialem geospatialem added has workaround Issues have a workaround available in the meantime. p - low Issue is non core or affecting less that 10% of people using the library estimate - 8 Requires input from team, consider smaller steps. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jul 19, 2023
@geospatialem
Copy link
Member

Stemmed from #5164

@jcfranco
Copy link
Member

As a workaround, remounting or recreating the submit button will properly wire up form submission. I know this isn't ideal or possible in some cases, but it's one option.

@geospatialem geospatialem added this to the 2023 November Priorities milestone Jul 26, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 26, 2023
@geospatialem geospatialem added the c-button Issues that pertain to the calcite-button component label Sep 11, 2023
@geospatialem
Copy link
Member

Reallocating to January due to prioritization and staffing availability.

@jcfranco jcfranco mentioned this issue Nov 14, 2023
Open
20 tasks
@geospatialem
Copy link
Member

Efforts will be tackled in #8126 first targeted in March, and we will proceed with the following issue post-March.

@geospatialem geospatialem added the blocked This issue is blocked by another issue. label Dec 12, 2024
@geospatialem geospatialem modified the milestones: Freezer, Stalled Dec 12, 2024
@github-actions github-actions bot added the p4 - not time sensitive User set priority status of p4 - not time sensitive label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. ArcGIS Velocity Issues logged by ArcGIS Velocity team members. blocked This issue is blocked by another issue. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-button Issues that pertain to the calcite-button component estimate - 8 Requires input from team, consider smaller steps. has workaround Issues have a workaround available in the meantime. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library p4 - not time sensitive User set priority status of p4 - not time sensitive
Projects
None yet
Milestone
Stalled
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @brettephillips