Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: combobox invalid prop and status #3406

Closed
sam11927 opened this issue Nov 2, 2021 · 7 comments
Closed

Enhancement: combobox invalid prop and status #3406

sam11927 opened this issue Nov 2, 2021 · 7 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. c-combobox Issues that pertain to the calcite-combobox and related components design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Milestone
2023 December Pri...

Comments

@sam11927
Copy link

sam11927 commented Nov 2, 2021

Description

Combobox should have an invalid state (add a status prop)

Acceptance Criteria

Combobox shows red border and can accept an input-message as well.

Which Component

calcite-combobox

Example Use Case

want to show that the combobox is a required field, so when someone clicks in and doesn't select something, set the status to invalid and display an error message (in the form of an input-message).
@sam11927 sam11927 added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 2, 2021
@jcfranco jcfranco removed their assignment Mar 11, 2022
@driskull driskull mentioned this issue Jun 3, 2022
Open
@macandcheese
Copy link
Contributor

@sam11927 do you still have a need for this invalid state on Combobox?

The input-message can be placed adjacent to the Combobox itself like this: https://codepen.io/mac_and_cheese/pen/bGxQEMv?editors=1000

@macandcheese macandcheese added the c-combobox Issues that pertain to the calcite-combobox and related components label Mar 22, 2023
@macandcheese macandcheese added the design Issues that need design consultation prior to development. label Apr 3, 2023
@geospatialem geospatialem changed the title Enhancement: combobox invalid status and input message compatability Enhancement: combobox invalid prop and status Apr 3, 2023
@geospatialem
Copy link
Member

Rescoped to fit the combobox's invalid status and include a prop.

@geospatialem geospatialem added this to the 2023 May Priorities milestone Apr 3, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Apr 3, 2023
@geospatialem geospatialem added 0 - new New issues that need assignment. estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed 1 - assigned Issues that are assigned to a sprint and a team member. design Issues that need design consultation prior to development. needs triage Planning workflow - pending design/dev review. labels Apr 3, 2023
@geospatialem geospatialem removed this from the 2023 May Priorities milestone Apr 3, 2023
@geospatialem
Copy link
Member

Part of a larger validation epic effort slotted for late 2023.

@geospatialem geospatialem mentioned this issue Jun 22, 2023
Open
@geospatialem geospatialem added the ready for dev Issues ready for development implementation. label Jul 21, 2023
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 21, 2023
@github-actions github-actions bot removed this from the Design Sprint Next milestone Jul 21, 2023
@github-actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem
Copy link
Member

Refer to the Figma file and image below:

image

@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 26, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@benelan benelan self-assigned this Nov 2, 2023
@benelan benelan added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Nov 2, 2023
@benelan benelan added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 30, 2023
@benelan benelan mentioned this issue Nov 30, 2023
Merged
benelan added a commit that referenced this issue Dec 1, 2023
@benelan
feat(combobox, checkbox, input-time-zone, select, text-area): add `st…
a44e9fe 
…atus` property (#8304)

**Related Issue:** #8057 #3406

## Summary

Add the `status` property to additional form components in preparation
of adding internal input messages for validation. I split these changes
out from #8305, which is where the new stories are.
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 12, 2023
@geospatialem geospatialem added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 19, 2023
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned benelan Dec 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 19, 2023
@geospatialem
Copy link
Member

Verified in 2.1.0 with https://codepen.io/geospatialem/pen/PoLYZoL with the status, validationIcon, and validationMessage props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. c-combobox Issues that pertain to the calcite-combobox and related components design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
9 participants
@jcfranco @alisonailea @macandcheese @geospatialem @benelan @DitwanP @sam11927 @ashetland @brittneytewks