Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree: length of the adjacent lines is not accurate #11035

Closed
2 of 6 tasks
anveshmekala opened this issue Dec 12, 2024 · 4 comments
Closed
2 of 6 tasks

tree: length of the adjacent lines is not accurate #11035

anveshmekala opened this issue Dec 12, 2024 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-tree Issues that pertain to the calcite-tree and related components Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-12-17 - Dec ...

Comments

@anveshmekala
Copy link
Contributor

anveshmekala commented Dec 12, 2024 •
edited by geospatialem
Loading

Check existing issues

Actual Behavior

When lines are enabled in tree , line associated with tree-item which has slotted children is inaccurate. cc @ashetland

Expected Behavior

lines have accurate length.

Reproduction Sample

https://codepen.io/anvesh-mekala/pen/YPKGdYJ

Reproduction Steps

  1. Open the CodePen.
  2. Observe the lines associated with WestCoast & Pacific NorthWest item.
  3. Observe line associated with WestCoast short in length. ( can be hard to spot and recommend zoom in)

Reproduction Version

2.13.2

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@anveshmekala anveshmekala added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. estimate - 2 Small fix or update, may require updates to tests. labels Dec 12, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Dec 12, 2024
@anveshmekala anveshmekala added the c-tree Issues that pertain to the calcite-tree and related components label Dec 12, 2024
@ashetland
Copy link

ashetland commented Dec 12, 2024 •
edited
Loading

I have my own label now?? 🤣 Thanks, github bot 🤖!

@anveshmekala anveshmekala mentioned this issue Dec 12, 2024
Merged
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Dec 12, 2024
@anveshmekala anveshmekala changed the title tree: lines are not aligned vertically. tree: length of the lines is not accurate Dec 12, 2024
@anveshmekala anveshmekala changed the title tree: length of the lines is not accurate tree: length of the adjacent lines is not accurate Dec 12, 2024
@anveshmekala anveshmekala self-assigned this Dec 12, 2024
@geospatialem geospatialem added Calcite (design) Issues logged by Calcite designers. and removed @ashetland labels Dec 12, 2024
@ashetland
Copy link

CleanShot 2024-12-12 at 12 51 21@2x
Bless you, @geospatialem

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Dec 12, 2024
anveshmekala added a commit that referenced this issue Dec 12, 2024
@anveshmekala
fix(tree): ensures lines length is accurate (#11036)
73fc55d 
**Related Issue:** #11035 

## Summary

Fixed `lines` length of parent `tree-item` with slotted children.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Dec 13, 2024

🍡 Verified locally on dev

See length of lines under WestCoast & Pacific NorthWest

Before:
image

After:
image

@DitwanP DitwanP closed this as completed Dec 13, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-tree Issues that pertain to the calcite-tree and related components Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
4 participants
@geospatialem @DitwanP @anveshmekala @ashetland