Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research: Look into using docs-json output target to improve Storybook integration #1079

Closed
jcfranco opened this issue Oct 7, 2020 · 4 comments
Closed

Research: Look into using docs-json output target to improve Storybook integration #1079

jcfranco opened this issue Oct 7, 2020 · 4 comments
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. p - low Issue is non core or affecting less that 10% of people using the library research Issues that require more in-depth research or multiple team members to resolve or make decision.
Milestone
Freezer

Comments

@jcfranco
Copy link
Member

jcfranco commented Oct 7, 2020 •
edited
Loading

@jcfranco commented on Fri Feb 14 2020

Background

Storybook 5.3 added support for web components, namely custom-elements.json. This could be used in conjunction with Stencil's JSON doc output to help simplify our setup.

Desired Outcome

Streamline the Stencil doc output + Storybook integration.

@jcfranco commented on Sat Feb 15 2020

This should probably wait until ionic-team/stencil#2196. The current JSON doc output from Stencil does not give a lot of info for Storybook to work its magic.
@jcfranco jcfranco mentioned this issue Oct 7, 2020
Closed
@jcfranco jcfranco added this to the v1.0.0-beta.42 milestone Oct 7, 2020
@jcfranco jcfranco added the research Issues that require more in-depth research or multiple team members to resolve or make decision. label Oct 7, 2020
@jcfranco jcfranco modified the milestones: v1.0.0-beta.42, Backlog Oct 7, 2020
@jcfranco jcfranco self-assigned this Oct 7, 2020
@jcfranco jcfranco added the 1 - assigned Issues that are assigned to a sprint and a team member. label Oct 7, 2020
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Nov 20, 2020
@kat10140 kat10140 added 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. and removed 1 - assigned Issues that are assigned to a sprint and a team member. Stale Issues or pull requests that have not had recent activity. labels Nov 25, 2020
@julio8a julio8a removed the 0 - new New issues that need assignment. label Jan 28, 2021
@julio8a
Copy link

julio8a commented Jul 16, 2021

Does this relate to the work @caripizza did?

@jcfranco
Copy link
Member Author

The Stencil team is looking into improving Storybook integration. I'll leave this open and revisit once there's an update. Related issues:

ionic-team/stencil#3104
ionic-team/stencil#2328
storybookjs/storybook#4600

@jcfranco jcfranco added the blocked This issue is blocked by another issue. label Dec 21, 2021
@jcfranco jcfranco added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 30, 2022
@jcfranco jcfranco removed their assignment Jun 30, 2022
@jcfranco jcfranco added the p - low Issue is non core or affecting less that 10% of people using the library label Jun 30, 2022
@jcfranco
Copy link
Member Author

This is no longer relevant after #10310. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. p - low Issue is non core or affecting less that 10% of people using the library research Issues that require more in-depth research or multiple team members to resolve or make decision.
Projects
None yet
Milestone
Freezer
Development

No branches or pull requests
4 participants
@jcfranco @alisonailea @julio8a @kat10140