Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chip] close button icon color token not working in some configurations #10428

Closed
2 of 6 tasks
DitwanP opened this issue Sep 27, 2024 · 2 comments
Closed
2 of 6 tasks

[Chip] close button icon color token not working in some configurations #10428

DitwanP opened this issue Sep 27, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2.13.1 patch

Comments

@DitwanP
Copy link
Contributor

DitwanP commented Sep 27, 2024

Check existing issues

Actual Behavior

The --calcite-chip-close-icon-color token for chip is not working when appearance is default and the kind is set to either "brand" or "inverse".

Look at the close icon for the two chips in the bottom left.
image

Expected Behavior

The color set by the token should be applied with this chip configuration.

Reproduction Sample

N/A

Reproduction Steps

  1. Setup a chip with the described properties and values.
  2. Change the close icon color with the --calcite-chip-close-icon-color token
  3. Notice the color not changing as expected

Reproduction Version

2.13.0

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@DitwanP DitwanP added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. design-tokens Issues requiring design tokens. labels Sep 27, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Sep 27, 2024
@DitwanP DitwanP added estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library labels Sep 27, 2024
@DitwanP DitwanP added this to the 2.13.1 patch milestone Sep 27, 2024
@DitwanP DitwanP removed the needs triage Planning workflow - pending design/dev review. label Sep 27, 2024
@DitwanP DitwanP added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 27, 2024
@DitwanP DitwanP mentioned this issue Sep 27, 2024
Open
@alisonailea alisonailea added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 7, 2024
@alisonailea alisonailea mentioned this issue Oct 7, 2024
Merged
alisonailea added a commit that referenced this issue Oct 10, 2024
@alisonailea
fix(chip): fix close icon color inconsistency (#10493)
e16f03b 
**Related Issue:** #10428

## Summary

Mitigates the --calcite-chip-close-icon-color token inconsistency.
<img width="229" alt="Screenshot 2024-10-07 at 9 20 41 AM"
src="https://github.com/user-attachments/assets/ec410639-2767-4c01-8479-c2e24801884d">
@alisonailea alisonailea added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned alisonailea Oct 10, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 10, 2024
@geospatialem
Copy link
Member

Verified by @DitwanP in the PR 🎉

benelan pushed a commit that referenced this issue Oct 11, 2024
@alisonailea @benelan
fix(chip): fix close icon color inconsistency (#10493)
b89164d 
**Related Issue:** #10428

## Summary

Mitigates the --calcite-chip-close-icon-color token inconsistency.
<img width="229" alt="Screenshot 2024-10-07 at 9 20 41 AM"
src="https://github.com/user-attachments/assets/ec410639-2767-4c01-8479-c2e24801884d">
benelan pushed a commit that referenced this issue Oct 11, 2024
@alisonailea @benelan
fix(chip): fix close icon color inconsistency (#10493)
80b75c2 
**Related Issue:** #10428

## Summary

Mitigates the --calcite-chip-close-icon-color token inconsistency.
<img width="229" alt="Screenshot 2024-10-07 at 9 20 41 AM"
src="https://github.com/user-attachments/assets/ec410639-2767-4c01-8479-c2e24801884d">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2.13.1 patch
Development

No branches or pull requests
3 participants
@alisonailea @geospatialem @DitwanP