Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel calcitePanelClose event emitted despite beforeClose failing #10220

Open
2 of 6 tasks
nwhittaker opened this issue Sep 4, 2024 · 2 comments
Open
2 of 6 tasks

Panel calcitePanelClose event emitted despite beforeClose failing #10220

nwhittaker opened this issue Sep 4, 2024 · 2 comments
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. blocked This issue is blocked by another issue. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
Stalled

Comments

@nwhittaker
Copy link
Contributor

Check existing issues

Actual Behavior

Given a closable <calcite-panel> with a beforeClose callback that rejects, clicking the panel's close button does not close it. However, the panel still emits a calcitePanelClose event.

Expected Behavior

The panel does not emit a calcitePanelClose event if it does not successfully close.

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/RwzqJwV

Reproduction Steps

  1. Visit the repro and open the console.
  2. Click the panel's close button and see "calcitePanelClose" is logged.

Reproduction Version

2.12.0

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Field Apps
@nwhittaker nwhittaker added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 4, 2024
@github-actions github-actions bot added ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Sep 4, 2024
@geospatialem geospatialem mentioned this issue Sep 16, 2024
Closed
@geospatialem geospatialem added the blocked This issue is blocked by another issue. label Sep 16, 2024
@geospatialem
Copy link
Member

Blocked by #10310

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Sep 16, 2024
@geospatialem geospatialem added this to the Stalled milestone Sep 16, 2024
@jcfranco
Copy link
Member

Other components with beforeClose prop to consider:

  • dialog
  • flow-item
  • modal
  • sheet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. blocked This issue is blocked by another issue. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
Stalled
Development

No branches or pull requests
3 participants
@jcfranco @nwhittaker @geospatialem