Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chip/ Chip Group] Enhance component's interactive states #10005

Open
2 of 21 tasks
geospatialem opened this issue Aug 8, 2024 · 1 comment
Open
2 of 21 tasks

[Chip/ Chip Group] Enhance component's interactive states #10005

geospatialem opened this issue Aug 8, 2024 · 1 comment
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Milestone
2025-02-25 - Feb ...

Comments

@geospatialem
Copy link
Member

geospatialem commented Aug 8, 2024 •
edited
Loading

Check existing issues

Description

Updates the chip's interactive states, for chip-group's with selection modes, as part of the larger epic in #9299.

Current state

image

Acceptance Criteria

Note that interaction state only apply to Chip Groups with selection modes.

  • kind="neutral" appearance="solid":
    • Update :hover background color to foreground.3
    • Update :press background color to border.3
  • kind="brand" appearance="solid":
    • Update :hover background color to brand.hover
    • Update :press background color to brand.press
  • kind="inverse" appearance="solid":
    • Update :hover background color to inverse.hover
    • Update :press background color to inverse.press
  • appearance="outline-fill" and appearance="outline":
    • Update :hover background color to foreground.2
    • Update :press background color to foreground.3
  • kind="neutral" and appearance="outline" OR appearance="outline-fill":
    • Update :hover outline colors to border.input
    • Update :press outline colors to text.3

image

Relevant Info

Figma file

Which Component

chip/chip-group

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. 0 - new New issues that need assignment. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. ready for dev Issues ready for development implementation. labels Aug 8, 2024
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 8, 2024
@github-actions github-actions bot removed this from the 2025-02-25 - Feb Main Release milestone Aug 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

cc @geospatialem, @brittneytewks

@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Aug 8, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 8, 2024
@geospatialem geospatialem mentioned this issue Aug 8, 2024
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2025-02-25 - Feb Milestone
Development

No branches or pull requests
1 participant
@geospatialem