Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenCloseComponents do not emit when setting --calcite-duration-factor #6604

Closed
jcfranco opened this issue Mar 15, 2023 · 3 comments
Closed

OpenCloseComponents do not emit when setting --calcite-duration-factor #6604

jcfranco opened this issue Mar 15, 2023 · 3 comments
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. estimate - 8 Requires input from team, consider smaller steps. has workaround Issues have a workaround available in the meantime. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2023 July Priorities

Comments

@jcfranco
Copy link
Member

Actual Behavior

Setting --calcite-duration-factor to 0 allows users to skip animations, but prevents (before)open/close events from being emitted.

cc @Elijbet

Expected Behavior

All (before)open/close events to be emitted regardless of transition duration.

Reproduction Sample

https://codepen.io/jcfranco/pen/WNgJemJ?editors=1010

Reproduction Steps

Click on toggle and notice how events are not emitted in the console.

Reproduction Version

1.0.8

Relevant Info

No response

Regression?

No response

Priority impact

p3 - not time sensitive

Impact

This will impact any users explicitly setting --calcite-duration-factor to 0 that rely on the before+open/close events.

Esri team

Calcite (dev)
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Mar 15, 2023
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Mar 15, 2023
This was referenced Mar 15, 2023
Closed
Closed
@geospatialem
Copy link
Member

Workaround: https://codepen.io/jcfranco/pen/gOdeVpq?editors=1000 (Context: #6582 (comment))

@geospatialem geospatialem added has workaround Issues have a workaround available in the meantime. p - low Issue is non core or affecting less that 10% of people using the library estimate - 8 Requires input from team, consider smaller steps. labels May 2, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label May 2, 2023
@jcfranco jcfranco mentioned this issue Jun 26, 2023
Merged
jcfranco added a commit that referenced this issue Jun 27, 2023
@jcfranco @benelan
fix(input-date-picker): reset active date picker date after closing (#…
91b2a1b 
…7219)

**Related Issue:** #6495 

## Summary

This ensures the active date is reset properly after a
`calcite-input-date-picker`'s date picker is closed (either by blurring
or selecting a date).

## Notes

* This adds an internal `reset` method that can be made public in the
future if needed.
* There was an existing `reset` method prior to these changes that seems
to clear the active date when the date picker is blurred or when
`Escape` is pressed. We should revisit this behavior since it was [added
when the input and date picker were a single
component](https://github.com/Esri/calcite-components/blob/v1.0.0-beta.22/src/components/calcite-date/calcite-date.tsx#L263-L270)
and it does seem odd to have the date-picker reset in these scenarios.
cc @macandcheese @SkyeSeitz @ashetland
* Utility test methods to interact with internal components were added
and tests were updated to leverage them
* Slightly increases the duration factor in the tests to work around
#6604

---------

Co-authored-by: Ben Elan <[email protected]>
benelan added a commit that referenced this issue Jun 28, 2023
@jcfranco @benelan
fix(input-date-picker): reset active date picker date after closing (#…
005836d 
…7219)

**Related Issue:** #6495 

## Summary

This ensures the active date is reset properly after a
`calcite-input-date-picker`'s date picker is closed (either by blurring
or selecting a date).

## Notes

* This adds an internal `reset` method that can be made public in the
future if needed.
* There was an existing `reset` method prior to these changes that seems
to clear the active date when the date picker is blurred or when
`Escape` is pressed. We should revisit this behavior since it was [added
when the input and date picker were a single
component](https://github.com/Esri/calcite-components/blob/v1.0.0-beta.22/src/components/calcite-date/calcite-date.tsx#L263-L270)
and it does seem odd to have the date-picker reset in these scenarios.
cc @macandcheese @SkyeSeitz @ashetland
* Utility test methods to interact with internal components were added
and tests were updated to leverage them
* Slightly increases the duration factor in the tests to work around
#6604

---------

Co-authored-by: Ben Elan <[email protected]>
@jcfranco
Copy link
Member Author

jcfranco commented Aug 3, 2023

This should be fixed by #7258.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 0 - new New issues that need assignment. labels Aug 3, 2023
@geospatialem
Copy link
Member

Verified in 1.5.0-next.38

@jcfranco jcfranco mentioned this issue Oct 25, 2024
Merged
jcfranco added a commit that referenced this issue Oct 25, 2024
@jcfranco
refactor: remove unnecessary skipAnimations delay workaround (#10614)
dd8d8c7 
**Related Issue:** N/A

## Summary

Removes workaround no longer needed after #6604.
@jcfranco jcfranco mentioned this issue Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. estimate - 8 Requires input from team, consider smaller steps. has workaround Issues have a workaround available in the meantime. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2023 July Priorities
Development

No branches or pull requests
2 participants
@jcfranco @geospatialem