Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap prover to sp1 in CDK #4

Open
alxiong opened this issue Jul 9, 2024 · 2 comments · May be fixed by EspressoSystems/cdk-validium-node#12
Open

Swap prover to sp1 in CDK #4

alxiong opened this issue Jul 9, 2024 · 2 comments · May be fixed by EspressoSystems/cdk-validium-node#12

Comments

@alxiong
Copy link
Collaborator

alxiong commented Jul 9, 2024

This task is tracked as this milestone on notion.

The idea is to update the CDK's dependency on zkevm-prover, the end goal for this issue is to run cd test && make run on cdk-validium-node repo, but with proof generated by sp1, and the aggregator (who will internally use prover) will submit the prove to a modified cdk-validium-contract.

roughly we need to:

  • start a trivial mocked sp1-prover executable (just write in rust) that provides similar interfaces like current zkevm-prover; and write a Dockerfile to launch it
    • understand what these APIs are (find if we can easily put up a mocked prover)
    • when a proof gen request is sent, simply fetch the stored proof artifacts/fixture (for the fibonaci program) and return
  • update cdk-validium-node/test/docker-compose.yml::zkevm-prover with our new docker image, also update respective config in test/config/*.config.json about the new prover service
  • switch FflonkVerifier.sol with Fibonaci.sol and update CDKValidum.sol's verify
    • rebuild the docker image, update test/docker-compose.yml::zkevm-mock-l1-network
  • rerun make run for e2e tests

What we don't need:

  • touch any DA or sequencer code: switching them out for espresso won't be our focus for now.
@philippecamacho
Copy link

philippecamacho commented Aug 27, 2024

Next steps:

  • Locally build the container image from the zip file Maksim shared with us. (CREATE TICKET)
  • Move existing work from cdk-validium to this repository. (CREATE TICKET)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants