Merge pull request #23 from EspressoSystems/fix/aggregator

Fix liveness bug in aggregator error handling
EspressoSystems · Feb 13, 2023 · ac693fc · ac693fc
2 parents 372cc59 + e66f0b1
commit ac693fc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/aggregator/aggregator.go b/aggregator/aggregator.go
@@ -307,18 +307,17 @@ func (a *Aggregator) buildFinalProof(ctx context.Context, prover proverInterface
 // build the final proof.  If no proof is provided it looks for a previously
 // generated proof.  If the proof is eligible, then the final proof generation
 // is triggered.
-func (a *Aggregator) tryBuildFinalProof(ctx context.Context, prover proverInterface, proof *state.Proof) (bool, error) {
+func (a *Aggregator) tryBuildFinalProof(ctx context.Context, prover proverInterface, proof *state.Proof) (proofBuilt bool, err error) {
 	log.Debugf("tryBuildFinalProof start prover { ID [%s], addr [%s] }", prover.ID(), prover.Addr())
 
-	var err error
 	if !a.canVerifyProof() {
 		log.Debug("Time to verify proof not reached")
 		return false, nil
 	}
 	log.Debug("Send final proof time reached")
 
 	defer func() {
-		if err != nil {
+		if !proofBuilt {
 			a.enableProofVerification()
 		}
 	}()

diff --git a/test/config/test.node.config.toml b/test/config/test.node.config.toml
@@ -90,7 +90,7 @@ MaxAllowedFailedCounter = 50
 Host = "0.0.0.0"
 Port = 50081
 RetryTime = "5s"
-VerifyProofInterval = "90s"
+VerifyProofInterval = "5s"
 TxProfitabilityCheckerType = "acceptall"
 TxProfitabilityMinReward = "1.1"
 ProofStatePollingInterval = "5s"