Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI quality #197

Open
sveitser opened this issue Aug 14, 2024 · 5 comments
Open

Improve CI quality #197

sveitser opened this issue Aug 14, 2024 · 5 comments

Comments

@sveitser
Copy link

sveitser commented Aug 14, 2024

Problems:

  • CI is flaky.
  • We are skipping tests.
  • CI test job is slow.
  • CI docker build is slow.
  • We have to use our own runners for the CI due to public runner limits.
@sveitser
Copy link
Author

sveitser commented Aug 14, 2024

One suggestion by @Ancient123 is to move the CI to buildjet. We can get more parallelism there and limits should be more forgiving compared to the public github runners.

@Ancient123
Copy link
Member

Bouncing this
into two build steps where one is on buildjet for ARM64 is also a good option.

We are doing that in espresso-sequencer now and it seems to work well.

@sveitser
Copy link
Author

sveitser commented Oct 1, 2024

@Sneh1999 @ImJeremyHe @zacshowa are you guys happy with the current CI or is it still a burden?

@Sneh1999
Copy link

Sneh1999 commented Oct 1, 2024

@Sneh1999 @ImJeremyHe @zacshowa are you guys happy with the current CI or is it still a burden?

I still see some flaky tests appear every now or then in PR's. I have to add them to ci_skip_tests file

@zacshowa
Copy link
Member

zacshowa commented Oct 3, 2024

I haven't seen many issues with the CI being flaky or anything. I also wouldn't object to discussion around improving it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants