New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal API update: clippy warning on gadget naming #56

Closed

zhenfeizhang opened this issue Apr 12, 2022 · 0 comments · Fixed by #57

Assignees

Contributor

zhenfeizhang commented Apr 12, 2022

Maybe: change all current is_xxx() (such as here) to check_xxx() and those that enforce and will return error if not SAT, we keep using xxx_gate() (like this)?
as long as we are consistent, I'm fine.

Originally posted by @alxiong in #53 (comment)

The text was updated successfully, but these errors were encountered:

zhenfeizhang changed the title ~~Maybe: change all current is_xxx() to check_xxx() and those that enforce and will return error if not SAT, we keep using xxx_gate()~~ change all current is_xxx() to check_xxx() and those that enforce and will return error if not SAT, we keep using xxx_gate()

zhenfeizhang self-assigned this

zhenfeizhang linked a pull request

that will close this issue

update API: is_xxx to check_xxx when self is mutated #57

Merged

6 tasks

zhenfeizhang mentioned this issue

update API: is_xxx to check_xxx when self is mutated #57

Merged

6 tasks

alxiong changed the title ~~change all current is_xxx() to check_xxx() and those that enforce and will return error if not SAT, we keep using xxx_gate()~~ internal API update: clippy warning on gadget naming

zhenfeizhang closed this as completed in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment