Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MerkleTreeGadget to be generic over HashGadget #142

Closed
2 tasks
tessico opened this issue Nov 18, 2022 · 1 comment · Fixed by #167
Closed
2 tasks

Refactor MerkleTreeGadget to be generic over HashGadget #142

tessico opened this issue Nov 18, 2022 · 1 comment · Fixed by #167
Assignees
@tessico
Milestone
Release 0.2.0

Comments

@tessico
Copy link
Contributor

tessico commented Nov 18, 2022

The WIP merkle tree circuit refactor is Rescue-hash specific.
We should have code that's polymorphic over different hash gadgets.

Tasks:

  • Introduce a HashGadget and make RescueGadget implement it
  • Make MerkleTreeGadget generic over HashGadget

See discussion here: #138 (comment)
@tessico tessico mentioned this issue Nov 18, 2022
Closed
6 tasks
@tessico tessico self-assigned this Nov 23, 2022
@tessico
Copy link
Contributor Author

tessico commented Nov 23, 2022

Indirectly related to better sponge APIs: #15

This was referenced Nov 25, 2022
Merged
Merged
@tessico tessico mentioned this issue Dec 13, 2022
Merged
6 tasks
@alxiong alxiong added this to the Release 0.2.0 milestone Dec 13, 2022
@tessico tessico mentioned this issue Dec 19, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tessico tessico

Labels
None yet
Projects
None yet
Milestone
Release 0.2.0
Development

Successfully merging a pull request may close this issue.

Digest-generic MerkleTreeGadget EspressoSystems/jellyfish
2 participants
@alxiong @tessico