Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HyperPlonk SNARKs #73

Merged
merged 6 commits into from
Sep 2, 2022
Merged

Refactor HyperPlonk SNARKs #73

merged 6 commits into from
Sep 2, 2022

Conversation

chancharles92
Copy link
Collaborator

@chancharles92 chancharles92 commented Sep 2, 2022

Part I of issue #68

  1. remove multiple witness commitments in the proof, use only the merged commitment.
  2. bugfix: add the product polynomial check prod(1, ..., 1, 0) = 1
  3. add degree() for custom gate struct.
  4. add more verification sanity checks.
  5. support multiple selector polynomials.
  6. add some bad path tests.
  7. define HyperPlonkIndex and simplify preprocess() API
  8. refactor structs SelectorRow/Column and WitnessRow/Column
  9. improve error messages.

Next PR:

  1. Simplify prove()/verify() functions, split it into multiple smaller functions.

@chancharles92 chancharles92 self-assigned this Sep 2, 2022
@chancharles92 chancharles92 requested a review from mrain September 2, 2022 16:34
Copy link
Contributor

@mrain mrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chancharles92 chancharles92 merged commit 32cc0c4 into main Sep 2, 2022
@chancharles92 chancharles92 deleted the binyi-refactor-snark branch November 22, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants