Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

product check APIs #41

Merged
merged 3 commits into from
Jul 14, 2022
Merged

product check APIs #41

merged 3 commits into from
Jul 14, 2022

Conversation

chancharles92
Copy link
Collaborator

close #40

@zhenfeizhang after implementing product_check, the permutation_check can be directly derived from prod_check, no need to have direct dependency to zero_check anymore.

zhenfeizhang
zhenfeizhang previously approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@zhenfeizhang zhenfeizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor editorial comments.

poly-iop/src/prod_check/mod.rs Outdated Show resolved Hide resolved
poly-iop/src/prod_check/mod.rs Outdated Show resolved Hide resolved
@chancharles92
Copy link
Collaborator Author

Thanks, comment addressed in 2842985

@chancharles92 chancharles92 merged commit 43131a0 into main Jul 14, 2022
@chancharles92 chancharles92 deleted the prodcheck-api branch July 14, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhenfeizhang zhenfeizhang zhenfeizhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Product check APIs
2 participants
@chancharles92 @zhenfeizhang