impl hyperplonk iop #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenfeizhang
force-pushed
the
hyperplonk-piop
branch
3 times, most recently
from
a297c31 to
1e11c52
Compare
hyperplonk/src/lib.rs
Outdated
| "evaluation dimension does not match".to_string(), | ||
| ))?; | ||
|
|
||
| let pi_opening = PCS::open(&pk.pcs_param, &Rc::new(pi_poly), &zero_check_proof.point)?; |
There was a problem hiding this comment.
Should this be an opening proof for w(zero_vec, point) instead of pi(point)? (no need to change if they are actually the same, but I doubt if it's the case.)
There was a problem hiding this comment.
fixed with 20a0ee2
zhenfeizhang
force-pushed
the
hyperplonk-piop
branch
from
31256bb to
43b66b8
Compare
zhenfeizhang
force-pushed
the
hyperplonk-piop
branch
from
c379a4e to
ef3a1b0
Compare
There was a problem hiding this comment.
@zhenfeizhang Added some comments regarding the integration test.
hyperplonk/src/lib.rs
Outdated
| // TODO: get the real max degree from gate_func | ||
| max_degree: 2, | ||
| // prod(x) has one more variable | ||
| num_variables: num_var + 1, |
There was a problem hiding this comment.
Should it be num_var + 1 + log_num_wires?
zhenfeizhang
commented
Jul 31, 2022
zhenfeizhang
commented
Jul 31, 2022
|
This has been a big PR and there are still many clean ups that I am working on. But feel free to review the functionalities... @chancharles92 |
chancharles92
approved these changes
Aug 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.