Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README #116

Merged
merged 5 commits into from
Jan 18, 2023
Merged

README #116

merged 5 commits into from
Jan 18, 2023

Conversation

chancharles92
Copy link
Collaborator

Close #115

@alxiong Can you check if the nix and direnv related sections are still correct? Thanks

@chancharles92 chancharles92 requested a review from alxiong January 13, 2023 16:44
alxiong
alxiong reviewed Jan 14, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
alxiong
alxiong approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@alxiong alxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to see a screenshot of benchmark directly inserted in the README, but if you think a hyperlink is sufficient. Also fine with me.

@chancharles92 chancharles92 merged commit 69070fc into main Jan 18, 2023
@chancharles92 chancharles92 deleted the readme branch January 18, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxiong alxiong alxiong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a more comprehensive README
2 participants
@chancharles92 @alxiong