Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider to use vec instead of hashmap for the actual polynomials #9

Closed
zhenfeizhang opened this issue May 11, 2022 · 1 comment
Closed

Consider to use vec instead of hashmap for the actual polynomials #9

zhenfeizhang opened this issue May 11, 2022 · 1 comment

Comments

@zhenfeizhang
Copy link
Contributor

Do we need a hashmap here? Is Vec sufficient?

Originally posted by @chancharles92 in #7 (comment)
@chancharles92
Copy link
Collaborator

After looking more into it, I realize that a HashMap is used to make sure that flatten_mle won't accidentally add the same MLE twice. Thus we can close this issue.

check here: https://github.com/EspressoSystems/hyperplonk/pull/7/files#diff-4d2b1d4d11a7437f4ac536f6a089fb989706e80649c525ded559413dea080f1bR53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhenfeizhang @chancharles92