Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrum integration: Ensure that the espresso block justification is serialized with batch data #781

Closed
nomaxg opened this issue Nov 29, 2023 · 7 comments

Comments

@nomaxg
Copy link
Contributor

nomaxg commented Nov 29, 2023

Currently, we include the block justification in L1IncomingMessageHeader, but this never actually makes it to the L1.

In EspressoSystems/nitro-espresso-integration#14, we introduce a new message type, L2MessageKind_EspressoTx, so we theoretically should be able to append the justification to the end of the l2 message and parse it accordingly.

@nomaxg
Copy link
Contributor Author

nomaxg commented Nov 29, 2023

@ImJeremyHe what do you think of this approach?

@sveitser
Copy link
Collaborator

@nomaxg I think that's fine. Once we no longer put the transactions in L1 do we still want to put the justification into L1? Do you recall what we did for the OP integration?

@nomaxg
Copy link
Contributor Author

nomaxg commented Nov 30, 2023

@nomaxg I think that's fine. Once we no longer put the transactions in L1 do we still want to put the justification into L1? Do you recall what we did for the OP integration?

Yeah we still include the justification at a minimum so that everything required for validation is available on the L1

@ImJeremyHe
Copy link
Member

Currently, we include the block justification in L1IncomingMessageHeader, but this never actually makes it to the L1.

L1IncomingMessageHeader is a part of the message and now we get the justification here. IIUC, the justification is serialized with batch data already.

@ImJeremyHe
Copy link
Member

I'm sorry, I used to think that all messages would be stored in L1 as they are. After debugging, I finally found that the header of the message is not completely made to L1. It seems that writing the justification into l2msg is an easy way. We can consider put the justification part to the first of L2Msg

@sveitser
Copy link
Collaborator

sveitser commented Dec 7, 2023

@ImJeremyHe @nomaxg we can close this right since

has been merged?

@nomaxg
Copy link
Contributor Author

nomaxg commented Dec 7, 2023

yep 👍

@sveitser sveitser closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants