-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arbitrum integration: Ensure that the espresso block justification is serialized with batch data #781
Comments
@ImJeremyHe what do you think of this approach? |
@nomaxg I think that's fine. Once we no longer put the transactions in L1 do we still want to put the justification into L1? Do you recall what we did for the OP integration? |
Yeah we still include the justification at a minimum so that everything required for validation is available on the L1 |
|
I'm sorry, I used to think that all messages would be stored in L1 as they are. After debugging, I finally found that the header of the message is not completely made to L1. It seems that writing the justification into |
@ImJeremyHe @nomaxg we can close this right since has been merged? |
yep 👍 |
Currently, we include the block justification in
L1IncomingMessageHeader
, but this never actually makes it to the L1.In EspressoSystems/nitro-espresso-integration#14, we introduce a new message type,
L2MessageKind_EspressoTx
, so we theoretically should be able to append the justification to the end of the l2 message and parse it accordingly.The text was updated successfully, but these errors were encountered: