Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parent] Support arbitrary payload bytes #747

Closed
2 tasks done
ggutoski opened this issue Nov 13, 2023 · 1 comment
Closed
2 tasks done

[parent] Support arbitrary payload bytes #747

ggutoski opened this issue Nov 13, 2023 · 1 comment
Assignees
@ggutoski
Labels
vid

Comments

@ggutoski
Copy link
Contributor

ggutoski commented Nov 13, 2023 •
edited
Loading

From #756 (comment) :

... we'll need to test with some blocks that weren't built by BlockPayload::build, since that function only builds "nice" blocks. We'll need to maliciously build some blocks with overlapping and truncated and out-of-order transactions.
@ggutoski ggutoski self-assigned this Nov 13, 2023
@ggutoski ggutoski mentioned this issue Nov 13, 2023
Closed
2 tasks
@ggutoski ggutoski added the vid label Nov 13, 2023
@ggutoski ggutoski changed the title T4: finish BlockPayload trait impl Finish BlockPayload trait impl Nov 13, 2023
@ggutoski ggutoski changed the title Finish BlockPayload trait impl Implement BlockPayload encode/decode aka to_bytes/from_bytes Nov 16, 2023
@ggutoski ggutoski mentioned this issue Nov 30, 2023
Closed
1 task
@ggutoski ggutoski changed the title Implement BlockPayload encode/decode aka to_bytes/from_bytes Support arbitrary payload bytes Dec 4, 2023
@ggutoski ggutoski mentioned this issue Dec 4, 2023
Merged
@ggutoski ggutoski changed the title Support arbitrary payload bytes [parent] Support arbitrary payload bytes Dec 8, 2023
@ggutoski
Copy link
Contributor Author

ggutoski commented Jan 8, 2024

closing in favour of #717

@ggutoski ggutoski closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggutoski ggutoski

Labels
vid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ggutoski