Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature gate HotShot trait implementations in espresso-types crate #2159

Open
imabdulbasit opened this issue Oct 10, 2024 · 0 comments · May be fixed by #2343
Open

feature gate HotShot trait implementations in espresso-types crate #2159

imabdulbasit opened this issue Oct 10, 2024 · 0 comments · May be fixed by #2343
Assignees

Comments

@imabdulbasit
Copy link
Contributor

The espresso-types crate currently compiles everything, including the HotShot trait implementations, which brings in a significant number of dependencies. However, not all external crates may require the HotShot trait functionality. Some might only need the core types, without the HotShot trait implementations or the SeqTypes (which implements the Hotshot NodeType trait).

To address this, we should introduce a feature (e.g., full or hotshot-impls) that allows users to optionally compile the HotShot trait implementations. By default, these would be excluded unless the feature is explicitly enabled, reducing compilation time and dependencies for users who don’t need them.

@imabdulbasit imabdulbasit self-assigned this Oct 10, 2024
@imabdulbasit imabdulbasit linked a pull request Dec 2, 2024 that will close this issue
@imabdulbasit imabdulbasit linked a pull request Dec 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant