Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up refactoring of Payload #1076

Closed
8 tasks
Tracked by #1039
philippecamacho opened this issue Feb 7, 2024 · 0 comments · Fixed by #1499
Closed
8 tasks
Tracked by #1039

Follow-up refactoring of Payload #1076

philippecamacho opened this issue Feb 7, 2024 · 0 comments · Fixed by #1499

Comments

@philippecamacho
Copy link
Contributor

philippecamacho commented Feb 7, 2024

The Payload struct has been redesigned (see #1012) however there are some pending improvements including:

  • Get rid of type TxTableEntry See
    pub type TxTableEntryWord = u32;
  • This type should be replaced with TableWord with the appropriate trait bounds which will likely involve the use of const generics.
    • Don't allow arithmetic directly on table entries: zero(), one(), checked_add_mut()
  • Change BlockPayload::Encode to avoid copying the payload.
  • Add unit tests for NameSpaceTable
  • Add unit tests for TxTable
  • Handle errors
  • See if the TxTable / NameSpaceTable can store only a reference to the payload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants