Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Refactor ParamsBuilder #46

Open
chancharles92 opened this issue May 18, 2022 · 1 comment
Open

Refactor ParamsBuilder #46

chancharles92 opened this issue May 18, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@chancharles92
Copy link
Contributor

chancharles92 commented May 18, 2022 •
edited
Loading

utils/params_builder.rs is actually making test debugging much harder as there are so many hardcoded values/logics inside. It's hard to directly debug other CAP API tests without figuring out the inner logic of ParamBuilder's implementations. We should try to refactor this helper struct at some point. @alxiong
@chancharles92 chancharles92 added enhancement New feature or request help wanted Extra attention is needed and removed help wanted Extra attention is needed labels May 18, 2022
@alxiong
Copy link
Contributor

alxiong commented Dec 5, 2022

a mocking library to consider: mockall which might lead to cleaner design. (not sure yet, need investigation)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chancharles92 @alxiong