Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH DEBT] - BlockPayload trait delete Metadata args and return vals #3300

Open
ggutoski opened this issue Jun 10, 2024 · 0 comments
Open
Assignees

Comments

@ggutoski
Copy link
Contributor

What is this task and why do we need to work on it?

The following methods all take an unneeded arg of type Self::Metadata:
from_bytes, builder_commitment, transactions.

The following methods all return an unneeded val of type Self::Metadata:
from_transactions, empty

Sometimes we actually clone the namespace table just to pass args or return a val that is never used!

What work will need to be done to complete this task?

No response

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

reviews from code owners

Branch work will be merged to (if not the default branch)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants