We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The following methods all take an unneeded arg of type Self::Metadata: from_bytes, builder_commitment, transactions.
Self::Metadata
from_bytes
builder_commitment
transactions
The following methods all return an unneeded val of type Self::Metadata: from_transactions, empty
from_transactions
empty
Sometimes we actually clone the namespace table just to pass args or return a val that is never used!
No response
reviews from code owners
The text was updated successfully, but these errors were encountered:
ggutoski
shenkeyao
No branches or pull requests
What is this task and why do we need to work on it?
The following methods all take an unneeded arg of type
Self::Metadata
:from_bytes
,builder_commitment
,transactions
.The following methods all return an unneeded val of type
Self::Metadata
:from_transactions
,empty
Sometimes we actually clone the namespace table just to pass args or return a val that is never used!
What work will need to be done to complete this task?
No response
Are there any other details to include?
No response
What are the acceptance criteria to close this issue?
reviews from code owners
Branch work will be merged to (if not the default branch)
No response
The text was updated successfully, but these errors were encountered: