Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt] - Remove # Panics from add_*_task functions #2542

Closed
ss-es opened this issue Feb 7, 2024 · 1 comment
Closed

[Tech Debt] - Remove # Panics from add_*_task functions #2542

ss-es opened this issue Feb 7, 2024 · 1 comment

Comments

@ss-es
Copy link
Contributor

ss-es commented Feb 7, 2024

What is this task and why do we need to work on it?

This is a minor tech debt task.

Task builders in mod.rs currently call unwrap(), which means they need a # Panics section:

This is probably not necessary, because we could just wrap register_registry into new in:

impl<HSTT: HotShotTaskTypes> HST<HSTT> {

What work will need to be done to complete this task?

No response

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

The TaskBuilder is reworked so that register_registry happens in new. The tid of HST should be a HotShotTaskId rather than an Option<HotShotTaskId>.

Branch work will be merged to (if not the default branch)

No response

@bfish713
Copy link
Collaborator

bfish713 commented Feb 7, 2024

I think I'm reworking a lot of this in: #2493. If it's not fixed in the PR feel free to comment

@ss-es ss-es closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants