We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
# Panics
add_*_task
This is a minor tech debt task.
Task builders in mod.rs currently call unwrap(), which means they need a # Panics section:
mod.rs
unwrap()
HotShot/crates/hotshot/src/tasks/mod.rs
Line 58 in 0eac853
This is probably not necessary, because we could just wrap register_registry into new in:
register_registry
new
HotShot/crates/task/src/task.rs
Line 187 in 0eac853
No response
The TaskBuilder is reworked so that register_registry happens in new. The tid of HST should be a HotShotTaskId rather than an Option<HotShotTaskId>.
TaskBuilder
tid
HST
HotShotTaskId
Option<HotShotTaskId>
The text was updated successfully, but these errors were encountered:
I think I'm reworking a lot of this in: #2493. If it's not fixed in the PR feel free to comment
Sorry, something went wrong.
No branches or pull requests
What is this task and why do we need to work on it?
This is a minor tech debt task.
Task builders in
mod.rs
currently callunwrap()
, which means they need a# Panics
section:HotShot/crates/hotshot/src/tasks/mod.rs
Line 58 in 0eac853
This is probably not necessary, because we could just wrap
register_registry
intonew
in:HotShot/crates/task/src/task.rs
Line 187 in 0eac853
What work will need to be done to complete this task?
No response
Are there any other details to include?
No response
What are the acceptance criteria to close this issue?
The
TaskBuilder
is reworked so thatregister_registry
happens innew
. Thetid
ofHST
should be aHotShotTaskId
rather than anOption<HotShotTaskId>
.Branch work will be merged to (if not the default branch)
No response
The text was updated successfully, but these errors were encountered: