Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ts][threejs] Custom shader ignores light and shadows #2606

Open
davidetan opened this issue Aug 19, 2024 · 2 comments
Open

[ts][threejs] Custom shader ignores light and shadows #2606

davidetan opened this issue Aug 19, 2024 · 2 comments
Assignees

Comments

@davidetan
Copy link
Collaborator

davidetan commented Aug 19, 2024

As reported by a user in this forum thread, the custom shader we use to render our meshes does not take into consideration lights and shadows.

It seems that using the onBeforeCompile callback is possible to modify the threejs base shader rather than replacing it.

See this official example (code here).

@davidetan davidetan self-assigned this Nov 7, 2024
@FloodGames
Copy link

FloodGames commented Nov 27, 2024

Is this shadow related?
I couldn't get this to work in Pixi Version 8 + this Spine version
Old working example custom Spine implementation + Pixi version 7:
https://pixijs.io/examples-v5/#/filters-advanced/pixie-shadow-filter.js

Is somebody able to get this shadow to work on the latest version of Spine?

@davidetan
Copy link
Collaborator Author

Is this shadow related? I couldn't get this to work in Pixi Version 8 + this Spine version Old working example custom Spine implementation + Pixi version 7: https://pixijs.io/examples-v5/#/filters-advanced/pixie-shadow-filter.js

Is somebody able to get this shadow to work on the latest version of Spine?

That's not related at all. It's definitely better to open a new issue about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants